Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ccoVeille
reviewed
Dec 20, 2025
Comment on lines
962
to
967
| func isComplexValue(v reflect.Value) bool { | ||
| _, ok := complexBaseKind(v) | ||
| return ok | ||
| } | ||
|
|
||
| func complexBaseKind(v reflect.Value) (reflect.Kind, bool) { |
Contributor
There was a problem hiding this comment.
Even if quite no one use complex integers in Go it's a thing. So here, I feel like the wording could be different.
But I don't have better wording that "complicated" but it may sound strange too
ccoVeille
reviewed
Dec 23, 2025
Akkadius
force-pushed
the
cmilesdev/depth-issue-fix
branch
from
1189729 to
07935f2
Compare
ccoVeille
reviewed
Dec 24, 2025
Comment on lines
+1252
to
+1272
| for { | ||
| switch v.Kind() { | ||
| case reflect.Interface: | ||
| if v.IsNil() { | ||
| return 0, false | ||
| } | ||
| v = v.Elem() | ||
| case reflect.Ptr: | ||
| if v.IsNil() { | ||
| return 0, false | ||
| } | ||
| v = v.Elem() | ||
| default: | ||
| switch v.Kind() { | ||
| case reflect.Struct, reflect.Map, reflect.Slice, reflect.Array: | ||
| return v.Kind(), true | ||
| default: | ||
| return 0, false | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Any reason to do not do this ?
Suggested change
| for { | |
| switch v.Kind() { | |
| case reflect.Interface: | |
| if v.IsNil() { | |
| return 0, false | |
| } | |
| v = v.Elem() | |
| case reflect.Ptr: | |
| if v.IsNil() { | |
| return 0, false | |
| } | |
| v = v.Elem() | |
| default: | |
| switch v.Kind() { | |
| case reflect.Struct, reflect.Map, reflect.Slice, reflect.Array: | |
| return v.Kind(), true | |
| default: | |
| return 0, false | |
| } | |
| } | |
| } | |
| for { | |
| switch v.Kind() { | |
| case reflect.Interface: | |
| if v.IsNil() { | |
| return 0, false | |
| } | |
| v = v.Elem() | |
| case reflect.Ptr: | |
| if v.IsNil() { | |
| return 0, false | |
| } | |
| v = v.Elem() | |
| case reflect.Struct, reflect.Map, reflect.Slice, reflect.Array: | |
| return v.Kind(), true | |
| default: | |
| return 0, false | |
| } | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Addresses #45